feat: enable problem bank button functionality [FC-0062] #1480
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @navinkarkera! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1480 +/- ##
=======================================
Coverage 93.01% 93.01%
=======================================
Files 1048 1048
Lines 20485 20494 +9
Branches 4332 4336 +4
=======================================
+ Hits 19054 19063 +9
Misses 1363 1363
Partials 68 68 ☔ View full report in Codecov by Sentry. |
navinkarkera
force-pushed
the
navin/improve-lib-buttons
branch
2 times, most recently
from
72b503f to
f8e00da
Compare
There was a problem hiding this comment.
LGTM 👍
Thank you for your work, @navinkarkera!
- I tested this using the instructions from the PR
- I read through the code
- I checked for accessibility issues
- Includes documentation
| <div | ||
| key={componentTemplate.displayName} | ||
| className="d-flex justify-content-between w-100 mb-2.5 align-items-end" | ||
| > |
Also, updates library v2 and problem bank icons and adds a beta tag based on api response.
* feat: add library v2 component in course * test: add test for lib v2 component * test: fix failing tests * refactor: remove ComponentPickerModal component Replace with standard modal and component picker components.
navinkarkera
force-pushed
the
navin/improve-lib-buttons
branch
from
b6ee727 to
7e442ae
Compare
|
@ChrisChV Merged open-craft#75 here. This is ready for you. |
|
@navinkarkera don't forget to add the |
ChrisChV
changed the title
@navinkarkera I don't see the beta badge on the buttons on the MFE unit page. Is it that expected?
|
|
@ChrisChV I am seeing it with this branch. You probably need to update
|
|
I found a related bug, but we can fix it separately: #1502 |
Description
Implements: #1462
Also, updates library v2 and problem bank icons and adds a beta tag based on api response.
Supporting information
Private-ref: FAL-3936Testing instructions
Problem Bankoption is working (adding a problem block). Verify the icons and beta badge forProblem BankandLibrary contentbuttons.